Issv3 hibernate schema #9375
Issv3 hibernate schema #9375
Conversation
|
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
| /** | ||
| * Constructor | ||
| */ | ||
| public HubFactory() { | ||
| // TODO document why this constructor is empty | ||
| } |
There was a problem hiding this comment.
Since there is currently nothing to initialize, this constructor can be removed.
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return new HashCodeBuilder().append(getFqdn()).append(getRootCa()).append(getMirrorCredentials()).toHashCode(); |
There was a problem hiding this comment.
JFYI, since you haven't used Apache Commons for equals() and toString(), you can just do:
return Objects.hash(getFqdn(), getRootCa(), getMirrorCredentials());
What does this PR change?
Java hibernate schema for the DB changes
GUI diff
No difference.
Documentation
https://github.com/SUSE/spacewalk/issues/25359
DONE
Test coverage
Unit tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/25348
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!